Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid Core: Restore use of server-side adapter without client-side adapter #7662

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

jorgeluisrocha
Copy link
Contributor

@jorgeluisrocha jorgeluisrocha commented Nov 3, 2021

Type of change

  • Bugfix

Description of change

Fixes a bug that requires client-side adapter codes to be imported for server-side bidding. This obviates the need to import client-side adapter specifications.

Other information

Issue: #6361
Issue: #6388

@jorgeluisrocha jorgeluisrocha changed the title requestBids bug fix for s2sBidders and getConfig Allow use of server-side adapter without client-side adapter Nov 3, 2021
@patmmccann patmmccann requested a review from a user November 4, 2021 18:00
@patmmccann patmmccann added bugfix needs 2nd review Core module updates require two approvals from the core team labels Nov 4, 2021
@patmmccann patmmccann changed the title Allow use of server-side adapter without client-side adapter Prebid Core: Restore use of server-side adapter without client-side adapter Nov 4, 2021
@jorgeluisrocha
Copy link
Contributor Author

the unit tests passed locally, but for some reason they are not passing on CircleCI. could someone restart the build? might just be flaky.

src/prebid.js Outdated Show resolved Hide resolved
@ChrisHuie
Copy link
Collaborator

@jorgeluisrocha we just merged a recent commit that fixes testing issues. If you pull in recent commits to master should fix the testing issue

@muuki88
Copy link
Collaborator

muuki88 commented Nov 10, 2021

Thanks for your pull request @jorgeluisrocha , but I'm really curious on how this fixes the issue you describe? This looks like a minimal refactoring of how the s2sConfig is fetched from the prebid configuration. Can you elaborate on how this removes the need for client side adapters?

@jorgeluisrocha
Copy link
Contributor Author

Thanks for your pull request @jorgeluisrocha , but I'm really curious on how this fixes the issue you describe? This looks like a minimal refactoring of how the s2sConfig is fetched from the prebid configuration. Can you elaborate on how this removes the need for client side adapters?

The method config.getConfig expects for there to be at most one argument in the parameter. The existing version of requestBids passes two arguments to the method - 's2sConfig' and a lambda function. What ends up occurring is if there is more than one argument, then rather than actually grabbing something from the config using _getConfig(), getConfig will simply add the arguments to subscribe to configuration updates.

Now, you may say "wouldn't adding to the subscriber be fine?". Well, there are three reasons why it is failing:

  1. Given this lambda function is meant to grab the results of getConfig, then at no point will this be possible given it was added to the subcriber. When would it ever actually get 's2sConfig' from the configuration? The sheer fact it was added to the subscriber means it will not happen.
  2. Even if the lambda function was correct and is able to grab something from getConfig, then at no point is the callback function ever taken off the subscriber, i.e., the promise is never fulfilled. If this does not happen, then s2sConfigs will remain empty.
  3. Even if the lambda function was correct and the callback function was taken off the subscriber correctly, then given how requestBids is written, all of this is irrelevant. The reason it would be irrelevant is because the machine will have run through the rest of requestBids anyway because there is nothing to indicate needing to wait for the results of the callback function. Even if s2sConfigs gets populated correctly, the moment when the contents of this array is used to filter through allBidders in a request to determine whether or not certain bidder requests should be resolved client-side will have passed by.

In short, the source of the issue is because there is an additional parameter when calling the getConfig method. This ends that.

@FilipStamenkovic FilipStamenkovic removed the needs 2nd review Core module updates require two approvals from the core team label Nov 15, 2021
@FilipStamenkovic FilipStamenkovic merged commit b927d8d into prebid:master Nov 15, 2021
FilipStamenkovic added a commit that referenced this pull request Nov 15, 2021
ChrisHuie pushed a commit that referenced this pull request Nov 15, 2021
cpabst pushed a commit to sovrn/Prebid.js that referenced this pull request Jan 10, 2022
…dapter (prebid#7662)

* requestBids bug fix for s2sBidders and getConfig

* merged duplicate variables in requestBids
cpabst pushed a commit to sovrn/Prebid.js that referenced this pull request Jan 10, 2022
rares-mihai-preda pushed a commit to Connatix/Prebid.js that referenced this pull request Jan 26, 2022
* DeepIntent Bid Adapter: instream video support added (#7494)

* instream video support added

* additional tests and docs added

* tests changed

* addressed comments

* add video type support

* tagId is mandatory

* test suite fixes

Co-authored-by: Sourabh Gandhe <sourabh@Sourabhs-MacBook-Pro.local>
Co-authored-by: Parth Shah <parth@deepintent.com>

* Gumgum Bid Adapter: add local time and timezone offset in requests (#7587)

* Gumgum: ADTS-164 Send local time and timezone offset in ad requests

* object existence check before accessing property

* Prebid 5.19.0 Release

* Increment pre version

* Ventes Bid Adapter: add new bid adapter (#7525)

* Ventes Avenues initial changes

* Ventes Avenues initial changes

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues

* Ventes Avenues Solved issues for user agent

* Added few more info

* Ventes Avenues Solved issues for user agent

* Jixiee Bid Adapter: add code to try get keywords from the page meta (#7592)

* Adapter does not seem capable of supporting advertiserDomains #6650
added response comment and some trivial code.

* removed a blank line at the end of file
added a space behind the // in comments

* in response to comment from reviewer. add the aspect of advertiserdomain in unit tests

* added the code to get the keywords from the meta tags if available.

* multibid module: Use array instead of string template to allow . in adUnitCode value (#7434)

* Use array instead of string template to allow . in adUnitCode value

* Change deepAccess param from string literal to array and modify unit test adUnitCode to include . in value

* Sortable Bid Adapter: Set gpid (#7608)

* Teads adapter: global placement id support (#7588)

* TheMediaGrid Bid Adapter: add playwire as alias (#7603)

* Added TheMediaGridNM Bid Adapter

* Updated required params for TheMediaGridNM Bid Adapter

* Update TheMediGridNM Bid Adapter

* Fix tests for TheMediaGridNM Bid Adapter

* Fixes after review for TheMediaGridNM Bid Adapter

* Add support of multi-format in TheMediaGrid Bid Adapter

* Update sync url for grid and gridNM Bid Adapters

* TheMediaGrid Bid Adapter: added keywords adUnit parameter

* Update TheMediaGrid Bid Adapter to support keywords from config

* Implement new request format for TheMediaGrid Bid Adapter

* Fix jwpseg params for TheMediaGrid Bid Adapter

* Update unit tests for The Media Grid Bid Adapter

* Fix typo in TheMediaGrid Bid Adapter

* Added test for jwTargeting in TheMediaGrid Bid Adapter

* The new request format was made by default in TheMediaGrid Bid Adapter

* Update userId format in ad request for TheMediaGrid Bid Adapter

* Added bidFloor parameter for TheMediaGrid Bid Adapter

* Fix for review TheMediaGrid Bid Adapter

* Support floorModule in TheMediaGrid Bid Adapter

* Fix empty bidfloor for TheMediaGrid Bid Adapter

* Some change to restart autotests

* Fix userIds format for TheMediaGrid Bid Adapter

* Remove digitrust userId from TheMediaGrid Bid Adapter

* Protocols was added in video section in ad request for TheMediaGrid Bid Adapter

* TheMediaGrid: fix trouble with alias using

* TheMediaGridNM: fix trouble with alias

* TheMediaGrid Bid Adapter: added support of PBAdSlot module

* TheMediaGrid Bid Adapter: fix typo

* GridNM Bid Adapter: use absent in params data from mediaTypes

* GridNM Bid Adapter: fix md file + add advertiserDomains support

* TheMediaGrid and gridNM Bid Adapter: minor netRevenue fixes

* gridNM Bid Adapter updates after review

* TheMediaGrid Bid Adapter: fix keywords workflow

* fix testing and kick off lgtm again

* TheMediaGrid: added ext.bidder.grid.demandSource processing

* TheMediaGrid: added user.id from fpd cookie

* TheMediaGrid: control cookie setting via bidder config

* TheMediaGrid: use localStorage instead cookie

* TheMediaGridNM Bid Adapter: update adapter to use /hbjson endpoint

* TheMediaGridNM: fix unnecessary conditions

* TheMediaGrid: fix bug with nurl field in response

* TheMediaGrid: update test

* TheMediaGridNM: fix possible bug with nurl

* TheMediaGrid: added alias as playwire

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* update appnexus dchain node

* fix typo

* Update nativoBidAdapter.js

* Remove duplicate segment handling (#7622)

* appnexus bid adapter - update impression urls logic (#7618)

* Send info about original CPM bid (#7623)

* Ats Analytics Adapter: listen to bid won events (#7577)

* ATS-analytics-adapter - add bid_won logic

* ATS-analytics-adapter - increase timeout in order to get bid_won events

* ATS-analytics-adapter - make bid_won timeout configurable

* ATS-analytics-adapter - change readme file

* Nativo Bid Adapter - Refactored spread adapter for IE11 support (#7625)

* Initial nativoBidAdapter document creation (js, md and spec)

* Fulling working prebid using nativoBidAdapter. Support for GDPR and CCPA in user syncs.

* Added defult size settings based on the largest ad unit. Added response body validation. Added consent to request url qs params.

* Changed bidder endpoint url

* Changed double quotes to single quotes.

* Reverted package-json.lock to remove modifications from PR

* Added optional bidder param 'url' so the ad server can force- match an existing placement

* Lint fix. Added space after if.

* Added new QS param to send various adUnit data to adapter endpopint

* Updated unit test for new QS param

* Added qs param to keep track of ad unit refreshes

* Updated bidMap key default value

* Updated refresh increment logic

* Refactored spread operator for IE11 support

Co-authored-by: Joshua Fledderjohn <jfledderjohn@nativo.com>

* support eids in outbrain (#7567)

* Send ortb2 object to sonobi bidding endpoint as fpd param (#7612)

* support for adserverTargeting in response (#7605)

Co-authored-by: Norbert Włosiński <norbert.wlosinski@justpremium.com>

* Between Bid Adapter & Airgrid rtd module: fix support for ie11 (#7619)

* Update betweenBidAdapter.js

* Update yahoosspBidAdapter.js

* Update adapterManager_spec.js

* Update adapterManager_spec.js

* Update airgridRtdProvider.js

* Update yahoosspBidAdapter.js

* Yahoo Bid Adapter: Support IE11 -> includes to indexOf (#7627)

* includes to indexOf

* lint

* TrustX Bid Adapter: fix for segments format (#7629)

* Add trustx adapter and tests for it

* update integration example

* Update trustx adapter

* Post-review fixes of Trustx adapter

* Code improvement for trustx adapter: changed default price type from gross to net

* Update TrustX adapter to support the 1.0 version

* Make requested changes for TrustX adapter

* Updated markdown file for TrustX adapter

* Fix TrustX adapter and spec file

* Update TrustX adapter: r parameter was added to ad request as cache buster

* Add support of gdpr to Trustx Bid Adapter

* Add wtimeout to ad request params for TrustX Bid Adapter

* TrustX Bid Adapter: remove last ampersand in the ad request

* Update TrustX Bid Adapter to support identical uids in parameters

* Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request

* Update TrustX Bid Adapter to support instream and outstream video

* Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter

* Update TrustX Bid Adapter to use refererInfo instead depricated function utils.getTopWindowUrl

* HOTFIX for referrer encodind in TrustX Bid Adapter

* Fix test for TrustX Bid Adapter

* TrustX Bid Adapter: added keywords passing support

* TrustX Bid Adapter: added us_privacy parameter in bid request

* TrustX Bid Adapter: fix us_privacy parameter in bid request

* Fix alias error for TrustX Bid Adapter

* TrustX Bid Adapter: added new request format

* TrustX Bid adapter: fix new format endpoint

* TrustX Bid Adapter: update md file to support useNewFormat parameter

* TrustX Bid Adapter: added additional sync url

* TrustX Bid Adapter: added check for enabled syncs number + added gdpr data to sync urls

* TrustX Bid Adapter: added support of meta.advertiserDomains

* TrustX Bid Adapter: added support rtd permutive and jwplayer for new and old request format

* TrustX Bid Adapter: Use new format by default + new keywords logic

* TrustX Bid Adapter: fix md file

* TrustX: Convert all id-like request fields to a string

* TrustX: added vastUrl support

* TrustX: fix segments format

* Delta Projects bid adapter: add new bid adapter (#7564)

* Delta Projects bid adapter: add new bid adapter

* Delta Projects bid adapter: revert accidental change to hello_world.html

* Remove unsupported functions by IE, add support for floor price

remove bidderParams which is not currently supported

remove bid parameter floor

remove unused function so linting is happy

Remove unused params in tests

use adservercurrency

include .js to make linter happy again

Co-authored-by: Boris-Tang <boris.tang@deltaprojects.com>

* operaads bid adapter: register user sync function (#7613)

* ADX-6971: register user sync function for operaads bid adapter

* fixup! ADX-6971: register user sync function for operaads bid adapter

* clean.io RTD Provider (#7449)

* Added sizeId 92 (#7631)

* Browi RTD provider:  code improvements (#7589)

* real time data module,
browsi sub module for real time data,
new hook bidsBackCallback,
fix for config unsubscribe

* change timeout&primary ad server only to auctionDelay
update docs

* support multiple providers

* change promise to callbacks
configure submodule on submodules.json

* bug fixes

* use Prebid ajax

* tests fix

* browsi real time data provider improvements

* real time data module,
browsi sub module for real time data,
new hook bidsBackCallback,
fix for config unsubscribe

* change timeout&primary ad server only to auctionDelay
update docs

* support multiple providers

* change promise to callbacks
configure submodule on submodules.json

* bug fixes

* use Prebid ajax

* tests fix

* browsi real time data provider improvements

* browsi rtd - refresh predictions & bid request data

* Browsi RTD provider improvements

* bid request key fix

* Revert "Added sizeId 92 (#7631)" (#7635)

This reverts commit 43e6abae703262a39481116ff011925e5589e43e.

* move dfp_ad_unit_code to imp.ext (#7637)

* Prebid Core: Fix Media Type Price Granularity (#7607)

* pass bidReq into targeting function and other fun stuff

* pass through bidReq

* allow granularity override

* Superfluous argument passed

* OTM Bid Adapter: Restore Adapter to pbjs 5 (#7616)

* support multiple size & update adapter

* fix test

* fix var

* fix vars

Co-authored-by: Kretsu Evgeniy <krecu.me@ya.ru>

* Prebid 5.20.0 release

* Prebid 6.0 (#7606)

* Update .babelrc.js

https://github.com/babel/babel/issues/7789

* Update browsers.json

* Update README.md

* Update .babelrc.js

* Update package.json

* Update package.json

* Update package.json

* Update package.json

* Update .babelrc.js

* Update package.json

* Update wdio.conf.js

* Prebid 6.0.0 release

* increment pre version

* adkernel Bid Adapter : added catapultx alias (#7435)

* Update adkernelBidAdapter.js

added catapultx alias

* Update adkernelBidAdapter.js

Co-authored-by: James <jt@catapultx.com>

* MerkleID: add check for typof configParams.endpoint on extendId (#7611)

* Chore: Added check for typof configParams.endpoint on extendId

* Chore: Fixed various test issues

* Chore: Removed stray console.log Console Log

* Removed Package-lock.json

* Chore: Added back original package-lock.json

* Nativo Bid Adapter: refactored validity check to be more informative  (#7632)

* Initial nativoBidAdapter document creation (js, md and spec)

* Fulling working prebid using nativoBidAdapter. Support for GDPR and CCPA in user syncs.

* Added defult size settings based on the largest ad unit. Added response body validation. Added consent to request url qs params.

* Changed bidder endpoint url

* Changed double quotes to single quotes.

* Reverted package-json.lock to remove modifications from PR

* Added optional bidder param 'url' so the ad server can force- match an existing placement

* Lint fix. Added space after if.

* Added new QS param to send various adUnit data to adapter endpopint

* Updated unit test for new QS param

* Added qs param to keep track of ad unit refreshes

* Updated bidMap key default value

* Updated refresh increment logic

* Refactored spread operator for IE11 support

* Updated isBidRequestValid check

* Refactored Object.enties to use Object.keys to fix CircleCI testing errors

Co-authored-by: Joshua Fledderjohn <jfledderjohn@nativo.com>

* Adomik Analytics Adapter: change bid.placementCode to bid.adUnitCode (#7610)

* AdomikAnalyticsAdapter: change placementCode to adUnitCode

* AdomikAnalyticsAdapter: split GET URLs only for MSIE browser

* Yieldlab Bid Adapter: add support for native mediatype (#7609)

* YL-3989: Accept NATIVE yieldprobe response (#2)

* YL-3989: Accept NATIVE response

* Fix: 'utils' is not defined  no-undef

* trigger GitHub actions

* Add multi-format example to the Yieldlab bidder documentation

* Reformat code

* Fix: Object doesn't support 'find'

Object doesn't support property or method 'find' in IE 11

* trigger GitHub actions

* Chore:Replace `filter` by `find` from ..array/find.js

* Fix typo

Co-authored-by: Christoph <29540638+kippsterr@users.noreply.github.com>

* clean up comments

* Codefuel Bid Adapter: bugfixes and remove config import (#7647)

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

 * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* fix lint issue in undertone adapter spec

* added user sync function to undertone adapter

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* added user sync function to undertone adapter

* added user sync function to undertone adapter

* revert package-lock.json

* added user sync function to undertone adapter

* Update undertoneBidAdapter.js

* Update browsers.json

* bugfix bidderurl

* bugfix bidderurl

* bugfix bidderurl

* tests

Co-authored-by: omerko <omer.koren@perion.com>
Co-authored-by: Omer Koren <omerko@users.noreply.github.com>
Co-authored-by: AnnaPerion <annat@perion.com>
Co-authored-by: Oran Hollaender <oran@perion.com>

* Sspbc Bid Adapter: update version and bugfixes (#7584)

* Update tests for sspBC adapter

Update tests for sspBC adapter:
- change userSync test (due to tcf param appended in v4.6)
- add tests for onBidWon and onTimeout

* [sspbc-adapter] 5.3 updates: content-type for notifications

* [sspbc-adapter] pass CTA to native bid

* [sspbc-5.3] keep pbsize for detected adunits

* [sspbc-5.3] increment adaptor ver

* [sspbc-adapter] maintenance update to sspBCBidAdapter

* remove yarn.lock

* Delete package-lock.json

* remove package-lock.jsonfrom pull request

* [sspbc-adapter] send pageViewId in request

* [sspbc-adapter] update pageViewId test

Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>

* Prebid Server Bid Adapter: auctionId to $.id UUID to $.source.tid + mergeDeep extPrebid (#7585)

* sourceTid

* revert unique to tid cuz easier

* deep merge extprebid

* add tests for changes

* .length duh

* test was incorrect

* no longer let this val be tid as it is not representitive

* fix test

* VidoomyBidAdapter: refactor cookie sync (#7601)

* fix: add delay between cookie sync calls

* fix(VidoomyBidAdapter): use default triggerPixel

* fix: use getUserSyncs hook to sync cookies

* fix: handle 204 no response without error log

* chore: refactor getUserSyncs

* test: update vidoomyBidAdapter tests

* fix: remove Macro

* fix: query params

* fix: gdpr consent

* fix: vidoomyBidAdapter tests

* fix: use USP_CONSENT in cookie sync urls

* TheMediaGrid Bid Adapter: added adlivetech as alias (#7649)

* Added TheMediaGridNM Bid Adapter

* Updated required params for TheMediaGridNM Bid Adapter

* Update TheMediGridNM Bid Adapter

* Fix tests for TheMediaGridNM Bid Adapter

* Fixes after review for TheMediaGridNM Bid Adapter

* Add support of multi-format in TheMediaGrid Bid Adapter

* Update sync url for grid and gridNM Bid Adapters

* TheMediaGrid Bid Adapter: added keywords adUnit parameter

* Update TheMediaGrid Bid Adapter to support keywords from config

* Implement new request format for TheMediaGrid Bid Adapter

* Fix jwpseg params for TheMediaGrid Bid Adapter

* Update unit tests for The Media Grid Bid Adapter

* Fix typo in TheMediaGrid Bid Adapter

* Added test for jwTargeting in TheMediaGrid Bid Adapter

* The new request format was made by default in TheMediaGrid Bid Adapter

* Update userId format in ad request for TheMediaGrid Bid Adapter

* Added bidFloor parameter for TheMediaGrid Bid Adapter

* Fix for review TheMediaGrid Bid Adapter

* Support floorModule in TheMediaGrid Bid Adapter

* Fix empty bidfloor for TheMediaGrid Bid Adapter

* Some change to restart autotests

* Fix userIds format for TheMediaGrid Bid Adapter

* Remove digitrust userId from TheMediaGrid Bid Adapter

* Protocols was added in video section in ad request for TheMediaGrid Bid Adapter

* TheMediaGrid: fix trouble with alias using

* TheMediaGridNM: fix trouble with alias

* TheMediaGrid Bid Adapter: added support of PBAdSlot module

* TheMediaGrid Bid Adapter: fix typo

* GridNM Bid Adapter: use absent in params data from mediaTypes

* GridNM Bid Adapter: fix md file + add advertiserDomains support

* TheMediaGrid and gridNM Bid Adapter: minor netRevenue fixes

* gridNM Bid Adapter updates after review

* TheMediaGrid Bid Adapter: fix keywords workflow

* fix testing and kick off lgtm again

* TheMediaGrid: added ext.bidder.grid.demandSource processing

* TheMediaGrid: added user.id from fpd cookie

* TheMediaGrid: control cookie setting via bidder config

* TheMediaGrid: use localStorage instead cookie

* TheMediaGridNM Bid Adapter: update adapter to use /hbjson endpoint

* TheMediaGridNM: fix unnecessary conditions

* TheMediaGrid: fix bug with nurl field in response

* TheMediaGrid: update test

* TheMediaGridNM: fix possible bug with nurl

* TheMediaGrid: added alias as playwire

* TheMediaGrid: added alias as adlivetech

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* move targets to packag.json (#7641)

* TrustX Bid Adapter: added support of PBAdSlot module (#7653)

* Add trustx adapter and tests for it

* update integration example

* Update trustx adapter

* Post-review fixes of Trustx adapter

* Code improvement for trustx adapter: changed default price type from gross to net

* Update TrustX adapter to support the 1.0 version

* Make requested changes for TrustX adapter

* Updated markdown file for TrustX adapter

* Fix TrustX adapter and spec file

* Update TrustX adapter: r parameter was added to ad request as cache buster

* Add support of gdpr to Trustx Bid Adapter

* Add wtimeout to ad request params for TrustX Bid Adapter

* TrustX Bid Adapter: remove last ampersand in the ad request

* Update TrustX Bid Adapter to support identical uids in parameters

* Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request

* Update TrustX Bid Adapter to support instream and outstream video

* Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter

* Update TrustX Bid Adapter to use refererInfo instead depricated function utils.getTopWindowUrl

* HOTFIX for referrer encodind in TrustX Bid Adapter

* Fix test for TrustX Bid Adapter

* TrustX Bid Adapter: added keywords passing support

* TrustX Bid Adapter: added us_privacy parameter in bid request

* TrustX Bid Adapter: fix us_privacy parameter in bid request

* Fix alias error for TrustX Bid Adapter

* TrustX Bid Adapter: added new request format

* TrustX Bid adapter: fix new format endpoint

* TrustX Bid Adapter: update md file to support useNewFormat parameter

* TrustX Bid Adapter: added additional sync url

* TrustX Bid Adapter: added check for enabled syncs number + added gdpr data to sync urls

* TrustX Bid Adapter: added support of meta.advertiserDomains

* TrustX Bid Adapter: added support rtd permutive and jwplayer for new and old request format

* TrustX Bid Adapter: Use new format by default + new keywords logic

* TrustX Bid Adapter: fix md file

* TrustX: Convert all id-like request fields to a string

* TrustX: added vastUrl support

* TrustX: fix segments format

* TrustX: added support of PBAdSlot module

* OpenX Bid adapter: Handle new user Ids (#7642)

* Saamba Bid Adapter: support  video params, and the floors module (#7448)

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Submit Advangelists Prebid Adapter Changes

* Update Bidder Code

To make adapter downloadable from git biddercode change is needed.

* Changes to Support Prebid 5.0.

https://github.com/prebid/Prebid.js/issues/6650
supporting advertiserDomains

https://github.com/prebid/Prebid.js/issues/6512
Support video params at the adunit level

https://github.com/prebid/Prebid.js/issues/6465

* Delete advangelistsBidAdapter.js.bak

* Delete advangelistsBidAdapter.md.bak

* Delete advangelistsBidAdapter_spec.js.bak

* Update advangelistsBidAdapter.js

* Add files via upload

* Update advangelistsBidAdapter.js

* Update advangelistsBidAdapter.js

* Update advangelistsBidAdapter.js

* Delete url.js

* Add files via upload

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update saambaaBidAdapter.js

* Update saambaaBidAdapter.js

* Update saambaaBidAdapter.js

* Update saambaaBidAdapter.js

Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com>

* IX Bid Adapter: capture errors in LS and send errors in request (#7630)

* capture errors in LS and send errors in request

* fix linting

* Deepintent: secure flag set using proper protocol value (#7655)

* VIS.X: fix url for timeout pixel (#7657)

* appnexus bid adapter - add support for brandId (#7658)

* alter logic on when to add bidder dchain

* Engageya bid adapter improvements (#7656)

* Validate image size

* Support net revenue

* Add widget view pixel

* Eplanning & Adapter Manager: fix testing of innerwidth to fix current build (#7679)

* console log innerWidth

* hmmm

* more debug

* weird

* if I change to larger mediaQuery it works I think

* stub window.top becasue we are mocking just window

* stub similar to sizeConfig test

* addressing window things

* i camel cased

* stub stuff right

* remove debug logs

* Smaato: Pass through bidRequest.schain (#7675)

Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com>

* expose seedtag gvl id for TFC2 support (#7674)

* docs only: remove reference to release notes page and some documentation links (#7672)

* Capture target demand provider (#7636)

- Use the provided storage manager
- Capture target demand provider & account id
- Add flag to trigger randomly-generated demo bid response

* Datablocks Bid Adapter: update url (#7680)

* updated url

* update metrics url

Co-authored-by: John Mayor <john@Johns-iMac.local>

* Datablocks Tests: fix failing tests (#7687)

* Datablocks Tests: fix failing tests

* take out source

* RichAudience Bid Adapter: Update GetFloors (#7664)

* Update GetFloors

* Update Strings must use singlequote

* Update push

* Update remove space

* Push Test

* Push Test 2

* New Attempt

* New Attempt 2

* New Attempt 3

* New Attempt 5

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

* Adhese Bid Adapter: Configurable vast as url (#7659)

* adpod category support test

* Revert "adpod category support test"

This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0.

* adpod category support test

* Revert "adpod category support test"

This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0.

* Adhese bid adapter: make the vastContentAsUrl setting configurable

Co-authored-by: Tim Sturtewagen <tim@adhese.com>
Co-authored-by: Paweł L <pawel.lankocz@adhese.eu>
Co-authored-by: westerschmal <30859973+westerschmal@users.noreply.github.com>

* add bidderDefaultFunction (#7628)

* IX Bid Adapter: add support for handling vastXML responses in PBJS (#7661)

* Add Index Exchange Video Adapter

* add support for handling vastXML responses in PBJS

* Remove Video Adapter code

Co-authored-by: Michael Harris <michael.harris@indexexchange.com>
Co-authored-by: Arven Ding <arven.ding@indexexchange.com>
Co-authored-by: IX Prebid Support <prebid.support@indexexchange.com>
Co-authored-by: Michael Burns <mlb7687@users.noreply.github.com>
Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com>
Co-authored-by: Kajan Umakanthan <umakajan@umakajan.com>

* PubMatic Bid Adapter: add Groupm  as alias bidder (#7692)

* Changed net revenue to True

* Added groupm as alias in pubmaticBidAdapter

* Added gvlid for groupm alias

* add space for linting

Co-authored-by: Azhar <azhar@L1119.local>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* GPT Pre Auction: setting GPID (#7671)

* set gpid

* fix gptPreAuction tests

* clean logic + add test

* Do not lint node_modules (#7689)

Running npm ci with npm 8.x installs dependencies in plugins/eslint/node_modules, which chokes the linter.

* send all custom params to the bidder (#7685)

* Revert "RichAudience Bid Adapter: Update GetFloors (#7664)" (#7695)

This reverts commit 6b027f5d960b6d37b9d6fd90d558494b390085a3.

* Prebid 6.1.0 Release

* increment pre version

* YieldOne Bid Adapter: add Flux Wrapper support. (#7555)

* YieldOne Bid Adapter: add Flux Wrapper support.

* YieldOne Bid Adapter: fix "import utils functions as needed and not the whole module (#7502)"

* YieldOne Bid Adapter: fix minor feedback.

Co-authored-by: kenichi-ichijo <kenichi-ichijo@dac.co.jp>

* PubMatic : Check for 'bid.ext.bidtype' key instead of 'bid.ext.Bidtype' key in translator response object. (#7683)

* Replaced bid.ext.BidType with bid.ext.bidType

* Replaced bidType with bidtype

Co-authored-by: Kapil Tuptewar <kapiltuptewar@L1290.local>

* Invibes Bid Adapter - support for adUnitCode differentiation in multiposition (#7652)

* Invibes Bid Adapter - support for adUnitCode differentiation in multiposition when same placement is used

* TheMediaGrid Bid Adapter: added adlivetech as alias (#7649)

* Added TheMediaGridNM Bid Adapter

* Updated required params for TheMediaGridNM Bid Adapter

* Update TheMediGridNM Bid Adapter

* Fix tests for TheMediaGridNM Bid Adapter

* Fixes after review for TheMediaGridNM Bid Adapter

* Add support of multi-format in TheMediaGrid Bid Adapter

* Update sync url for grid and gridNM Bid Adapters

* TheMediaGrid Bid Adapter: added keywords adUnit parameter

* Update TheMediaGrid Bid Adapter to support keywords from config

* Implement new request format for TheMediaGrid Bid Adapter

* Fix jwpseg params for TheMediaGrid Bid Adapter

* Update unit tests for The Media Grid Bid Adapter

* Fix typo in TheMediaGrid Bid Adapter

* Added test for jwTargeting in TheMediaGrid Bid Adapter

* The new request format was made by default in TheMediaGrid Bid Adapter

* Update userId format in ad request for TheMediaGrid Bid Adapter

* Added bidFloor parameter for TheMediaGrid Bid Adapter

* Fix for review TheMediaGrid Bid Adapter

* Support floorModule in TheMediaGrid Bid Adapter

* Fix empty bidfloor for TheMediaGrid Bid Adapter

* Some change to restart autotests

* Fix userIds format for TheMediaGrid Bid Adapter

* Remove digitrust userId from TheMediaGrid Bid Adapter

* Protocols was added in video section in ad request for TheMediaGrid Bid Adapter

* TheMediaGrid: fix trouble with alias using

* TheMediaGridNM: fix trouble with alias

* TheMediaGrid Bid Adapter: added support of PBAdSlot module

* TheMediaGrid Bid Adapter: fix typo

* GridNM Bid Adapter: use absent in params data from mediaTypes

* GridNM Bid Adapter: fix md file + add advertiserDomains support

* TheMediaGrid and gridNM Bid Adapter: minor netRevenue fixes

* gridNM Bid Adapter updates after review

* TheMediaGrid Bid Adapter: fix keywords workflow

* fix testing and kick off lgtm again

* TheMediaGrid: added ext.bidder.grid.demandSource processing

* TheMediaGrid: added user.id from fpd cookie

* TheMediaGrid: control cookie setting via bidder config

* TheMediaGrid: use localStorage instead cookie

* TheMediaGridNM Bid Adapter: update adapter to use /hbjson endpoint

* TheMediaGridNM: fix unnecessary conditions

* TheMediaGrid: fix bug with nurl field in response

* TheMediaGrid: update test

* TheMediaGridNM: fix possible bug with nurl

* TheMediaGrid: added alias as playwire

* TheMediaGrid: added alias as adlivetech

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* move targets to packag.json (#7641)

* TrustX Bid Adapter: added support of PBAdSlot module (#7653)

* Add trustx adapter and tests for it

* update integration example

* Update trustx adapter

* Post-review fixes of Trustx adapter

* Code improvement for trustx adapter: changed default price type from gross to net

* Update TrustX adapter to support the 1.0 version

* Make requested changes for TrustX adapter

* Updated markdown file for TrustX adapter

* Fix TrustX adapter and spec file

* Update TrustX adapter: r parameter was added to ad request as cache buster

* Add support of gdpr to Trustx Bid Adapter

* Add wtimeout to ad request params for TrustX Bid Adapter

* TrustX Bid Adapter: remove last ampersand in the ad request

* Update TrustX Bid Adapter to support identical uids in parameters

* Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request

* Update TrustX Bid Adapter to support instream and outstream video

* Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter

* Update TrustX Bid Adapter to use refererInfo instead depricated function utils.getTopWindowUrl

* HOTFIX for referrer encodind in TrustX Bid Adapter

* Fix test for TrustX Bid Adapter

* TrustX Bid Adapter: added keywords passing support

* TrustX Bid Adapter: added us_privacy parameter in bid request

* TrustX Bid Adapter: fix us_privacy parameter in bid request

* Fix alias error for TrustX Bid Adapter

* TrustX Bid Adapter: added new request format

* TrustX Bid adapter: fix new format endpoint

* TrustX Bid Adapter: update md file to support useNewFormat parameter

* TrustX Bid Adapter: added additional sync url

* TrustX Bid Adapter: added check for enabled syncs number + added gdpr data to sync urls

* TrustX Bid Adapter: added support of meta.advertiserDomains

* TrustX Bid Adapter: added support rtd permutive and jwplayer for new and old request format

* TrustX Bid Adapter: Use new format by default + new keywords logic

* TrustX Bid Adapter: fix md file

* TrustX: Convert all id-like request fields to a string

* TrustX: added vastUrl support

* TrustX: fix segments format

* TrustX: added support of PBAdSlot module

* OpenX Bid adapter: Handle new user Ids (#7642)

* Saamba Bid Adapter: support  video params, and the floors module (#7448)

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Submit Advangelists Prebid Adapter Changes

* Update Bidder Code

To make adapter downloadable from git biddercode change is needed.

* Changes to Support Prebid 5.0.

https://github.com/prebid/Prebid.js/issues/6650
supporting advertiserDomains

https://github.com/prebid/Prebid.js/issues/6512
Support video params at the adunit level

https://github.com/prebid/Prebid.js/issues/6465

* Delete advangelistsBidAdapter.js.bak

* Delete advangelistsBidAdapter.md.bak

* Delete advangelistsBidAdapter_spec.js.bak

* Update advangelistsBidAdapter.js

* Add files via upload

* Update advangelistsBidAdapter.js

* Update advangelistsBidAdapter.js

* Update advangelistsBidAdapter.js

* Delete url.js

* Add files via upload

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update saambaaBidAdapter.js

* Update saambaaBidAdapter.js

* Update saambaaBidAdapter.js

* Update saambaaBidAdapter.js

Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com>

* IX Bid Adapter: capture errors in LS and send errors in request (#7630)

* capture errors in LS and send errors in request

* fix linting

* Deepintent: secure flag set using proper protocol value (#7655)

* VIS.X: fix url for timeout pixel (#7657)

* appnexus bid adapter - add support for brandId (#7658)

* Invibes Bid Adapter - redo tests

* Engageya bid adapter improvements (#7656)

* Validate image size

* Support net revenue

* Add widget view pixel

* Eplanning & Adapter Manager: fix testing of innerwidth to fix current build (#7679)

* console log innerWidth

* hmmm

* more debug

* weird

* if I change to larger mediaQuery it works I think

* stub window.top becasue we are mocking just window

* stub similar to sizeConfig test

* addressing window things

* i camel cased

* stub stuff right

* remove debug logs

* Smaato: Pass through bidRequest.schain (#7675)

Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com>

* expose seedtag gvl id for TFC2 support (#7674)

* docs only: remove reference to release notes page and some documentation links (#7672)

* Capture target demand provider (#7636)

- Use the provided storage manager
- Capture target demand provider & account id
- Add flag to trigger randomly-generated demo bid response

* Invibes Bid Adapter - added unit tests for adUnitCode logic

* Invibes Bid Adapter - fixed lint

* Datablocks Bid Adapter: update url (#7680)

* updated url

* update metrics url

Co-authored-by: John Mayor <john@Johns-iMac.local>

* Datablocks Tests: fix failing tests (#7687)

* Datablocks Tests: fix failing tests

* take out source

* RichAudience Bid Adapter: Update GetFloors (#7664)

* Update GetFloors

* Update Strings must use singlequote

* Update push

* Update remove space

* Push Test

* Push Test 2

* New Attempt

* New Attempt 2

* New Attempt 3

* New Attempt 5

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

* Adhese Bid Adapter: Configurable vast as url (#7659)

* adpod category support test

* Revert "adpod category support test"

This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0.

* adpod category support test

* Revert "adpod category support test"

This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0.

* Adhese bid adapter: make the vastContentAsUrl setting configurable

Co-authored-by: Tim Sturtewagen <tim@adhese.com>
Co-authored-by: Paweł L <pawel.lankocz@adhese.eu>
Co-authored-by: westerschmal <30859973+westerschmal@users.noreply.github.com>

* add bidderDefaultFunction (#7628)

* IX Bid Adapter: add support for handling vastXML responses in PBJS (#7661)

* Add Index Exchange Video Adapter

* add support for handling vastXML responses in PBJS

* Remove Video Adapter code

Co-authored-by: Michael Harris <michael.harris@indexexchange.com>
Co-authored-by: Arven Ding <arven.ding@indexexchange.com>
Co-authored-by: IX Prebid Support <prebid.support@indexexchange.com>
Co-authored-by: Michael Burns <mlb7687@users.noreply.github.com>
Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com>
Co-authored-by: Kajan Umakanthan <umakajan@umakajan.com>

* PubMatic Bid Adapter: add Groupm  as alias bidder (#7692)

* Changed net revenue to True

* Added groupm as alias in pubmaticBidAdapter

* Added gvlid for groupm alias

* add space for linting

Co-authored-by: Azhar <azhar@L1119.local>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* GPT Pre Auction: setting GPID (#7671)

* set gpid

* fix gptPreAuction tests

* clean logic + add test

* Do not lint node_modules (#7689)

Running npm ci with npm 8.x installs dependencies in plugins/eslint/node_modules, which chokes the linter.

* send all custom params to the bidder (#7685)

* Revert "RichAudience Bid Adapter: Update GetFloors (#7664)" (#7695)

This reverts commit 6b027f5d960b6d37b9d6fd90d558494b390085a3.

* Prebid 6.1.0 Release

* increment pre version

* Invibes Bid Adapter - support for adUnitCode differentiation in multiposition when same placement is used

* Invibes Bid Adapter - redo tests

* Invibes Bid Adapter - added unit tests for adUnitCode logic

* Invibes Bid Adapter - fixed lint

Co-authored-by: TheMediaGrid <44166371+TheMediaGrid@users.noreply.github.com>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Co-authored-by: PWyrembak <paul@trustx.org>
Co-authored-by: Luigi Sayson <48766825+luigi-sayson@users.noreply.github.com>
Co-authored-by: NeerajKrRai <55957265+NeerajKrRai@users.noreply.github.com>
Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com>
Co-authored-by: Kajan Umakanthan <umakajan@umakajan.com>
Co-authored-by: Parth Shah <parth@deepintent.com>
Co-authored-by: Michael Kuryshev <mk0x9@users.noreply.github.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Co-authored-by: Miko Stern <37616476+mikomgk@users.noreply.github.com>
Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com>
Co-authored-by: el-chuck <be.pickenbrock@gmail.com>
Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com>
Co-authored-by: Yohan Boutin <yohan@seedtag.com>
Co-authored-by: Scott Menzer <scott@id5.io>
Co-authored-by: Samuel Dobbie <samueldobbie@users.noreply.github.com>
Co-authored-by: jmayor <john@johnmayor.ca>
Co-authored-by: John Mayor <john@Johns-iMac.local>
Co-authored-by: Rich Audience <integrations@richaudience.com>
Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>
Co-authored-by: mefjush <mefjush@gmail.com>
Co-authored-by: Tim Sturtewagen <tim@adhese.com>
Co-authored-by: Paweł L <pawel.lankocz@adhese.eu>
Co-authored-by: westerschmal <30859973+westerschmal@users.noreply.github.com>
Co-authored-by: eknis <tem.eknis@gmail.com>
Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com>
Co-authored-by: Michael Harris <michael.harris@indexexchange.com>
Co-authored-by: Arven Ding <arven.ding@indexexchange.com>
Co-authored-by: IX Prebid Support <prebid.support@indexexchange.com>
Co-authored-by: Michael Burns <mlb7687@users.noreply.github.com>
Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com>
Co-authored-by: pm-azhar-mulla <75726247+pm-azhar-mulla@users.noreply.github.com>
Co-authored-by: Azhar <azhar@L1119.local>
Co-authored-by: dgirardi <demetrio.girardi@gmail.com>
Co-authored-by: antoinezaz <antoine.zazzera@gmail.com>
Co-authored-by: Jason Snellbaker <jsnellbaker@appnexus.com>

* Smartx Bid Adapter: enable pbjs log for bid request & outstream player config adjustment (#7701)

* Add smartclipBidAdapter

* smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions

* - made outstream player configurable

* remove wrong named files

* camelcase

* fix

* Out-Stream render update to SmartPlay 5.2

* ESlint fix

* ESlint fix

* ESlint fix

* adjust tests, fixes

* ESlint

* adjusted desired bitrate examples

* added bid.meta.advertiserDomains support

* bug fix for numeric elementID outstream render

* fix renderer url

* support for floors module

* bugfixes to be openRTB 2.5 compliant

* update internal renderer usage

* remove unused outstream_function logic

* bugfix outstream options for default outstream renderer configuration

* [PREB-10] fix empty title not configurable

* add pbjs version

* testing with outstream 5.3.0

* pbjs version into content.ext

* made visibilityThreshold configurable

* adjust position of pbjs version

Co-authored-by: smartclip AdTechnology <adtech@smartclip.com>
Co-authored-by: Gino Cirlini <adtech@smartclip.tv>

* Undertone Bid Adapter - update canonical and referral URLs 31599 (#7693)

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

 * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* fix lint issue in undertone adapter spec

* added user sync function to undertone adapter

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* added user sync function to undertone adapter

* added user sync function to undertone adapter

* revert package-lock.json

* added user sync function to undertone adapter

* Update undertoneBidAdapter.js

* Update browsers.json

* sending both page url & commons.referrer

* revert indentation

* sending both commons.canonicalUrl & commons.referrer

Co-authored-by: omerko <omer.koren@perion.com>
Co-authored-by: Omer Koren <omerko@users.noreply.github.com>
Co-authored-by: AnnaPerion <annat@perion.com>
Co-authored-by: Oran Hollaender <oran@perion.com>
Co-authored-by: tamirnPerion <44399211+tamirnPerion@users.noreply.github.com>

* Added option to pass a user id through ortb2. (#7639)

* Prebid Core: Restore use of server-side adapter without client-side adapter (#7662)

* requestBids bug fix for s2sBidders and getConfig

* merged duplicate variables in requestBids

* Revert "Prebid Core: Restore use of server-side adapter without client-side adapter (#7662)" (#7708)

This reverts commit b927d8d21628c42cbbfc6bfac8823528f53a25da.

* use ajax() craftBidAdapter (#7699)

* Tappx Bid Adapter: add vendor id (#7709)

* Tappx :: Add vendor id

* add unit test

Co-authored-by: Albert Grandes <agrandes@tappx.com>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* Gumgum Bid Adapter: add adUnitCode to requests (#7704)

* Gumgum: add adUnitCode to requests

* added unit test

* simplify comment since ticket name is available

* AdPlus Bid Adapter: add new bid adapter (#7668)

* New bid adapter-AdPlus Bid Adapter added

* AdPlus bid adapter session storage issue fix

Co-authored-by: TCCDENIZ <cansin.deniz@turkcell.com.tr>

* Prebid Core: add new setting to allow zero cpm bids (#7633)

* add new setting to allow zero cpm bids

* move logic to bidderSettings

* update logic

* Rich Audience Bid Adapter: changes per pr 7664 (#7697)

* Update yahoosspBidAdapter.md (#7721)

* Relaido Bid Adapter: Modified to response ads in a single API request. (#7598)

* add relaido adapter

* remove event listener

* fixed UserSyncs and e.data

* fix conflicts

* make single requests.

Co-authored-by: ishigami_shingo <s.ishigami@relaido.co.jp>
Co-authored-by: cmertv-sishigami <s.ishigami@cmertv.com>
Co-authored-by: t_bun <t.bun@cmertv.com>

* fix link to adapters (#7727)

adapters are inside `/modules`

* Missena Bid Adapter: add back adapter to latest prebid version (#7648)

* Re-enable Missena Adapter

* Refactor utils use

* Add advertiserDomains to spec testing.

* Ventes Bid Adapter: fix web placement support (#7715)

* Ventes Avenues initial changes

* Ventes Avenues initial changes

* Support Web Placments

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* add intersection RtdProvider and spec (#7710)

Co-authored-by: atkachov <atkachov@admixer.ua>

* Smaato: Pass through instl (#7725)

Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com>

* goldbachXandr Bid Adapter: add new bid adapter (#7650)

* added goldbach adapter

* updated logic

* removed serverResponse condition from interpretResponse

* removed xandr reference

* fixed typo

* removed gvlid and storage manager

* changed utils import to named

* AdmixerBidAdapter: add native media type support (#7717)

* add native support

* fix single quote linting error

Co-authored-by: atkachov <atkachov@admixer.ua>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* iprom Bid Adapter: restore adapter in prebid master (#7700)

* Restore ipromBidAdapter >5.x

* Import only used utils functions instead of all

Co-authored-by: Gašper <gasper.zagar@iprom.si>

* LuponMedia Bid Adapter: add adapter back to prebid master (#7602)

* LuponMedia BidAdapter 5.X

* manually try to kick off circleci tests

* kick off tests

* kick off tests

* Update luponmediaBidAdapter.js

using isFn from utils

Co-authored-by: adxpremium <support@luponmedia.com>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* VIS.X Bid Adapter: check ad slot existence (#7730)

* VIS.X: add ad slot check

* VIS.X: update ad slot check helpers

Co-authored-by: Vladimir Fedoseev <vladimir.fedoseev@yoc.com>

* showheroes-bs Bid Adapter: fix for outstream render (#7604)

* add ShowHeroes Adapter

* ShowHeroes adapter - expanded outstream support

* Revert "ShowHeroes adapter - expanded outstream support"

This reverts commit bfcdb913b52012b5afbf95a84956b906518a4b51.

* ShowHeroes adapter - expanded outstream support

* ShowHeroes adapter - fixes (#4222)

* ShowHeroes adapter - banner and outstream fixes (#4222)

* ShowHeroes adapter - description and outstream changes (#4222)

* ShowHeroes adapter - increase test coverage and small fix

* ShowHeroes Adapter - naming convention issue

* Mixed AdUnits declaration support

* ITDEV-4723 PrebidJS adapter support with SupplyChain module object

* ITDEV-4723 Fix tests

* ITDEV-4723 New entry point

* showheroes-bsBidAdapter: Add support for advertiserDomains

* showheroes-bsBidAdapter: hotfix for outstream render

* showheroes-bsBidAdapter: update renderer url

Co-authored-by: veranevera <vera.yukhina@showheroes.com>
Co-authored-by: Elizaveta Voziyanova <44549195+h2p4x8@users.noreply.github.com>

* Revert "showheroes-bs Bid Adapter: fix for outstream render (#7604)" (#7734)

This reverts commit 23f4da7b503d8e87da52837d454e62c22589c2d1.

* Testing Browserlist: remove browsers for testing that are not being built as a target (#7696)

* Build: remove browsers for testing not building to

* update chrome version

* change chrome to v95

* upgrade to v93 for firefox

* try latest flag with chrome

* update to latest can-i-use for new browsers

* Revert "update to latest can-i-use for new browsers"

This reverts commit 9e07037d3461ea098ca785ebabe33c41dab7afe7.

* change to latest version and oldest chrome

* fix os for safari

* update big sur browser

* try again with mac version os

* fix typo

* fix catalina safari version

* update concurrency

* freewheel-ssp Bid Adapter: add schain in request params (#7504)

* freewheel add schain in the request

* Fix an error on test case

* Update freewheel-sspBidAdapter_spec.js

Update test case

* Update freewheel-sspBidAdapter_spec.js

fix the test

* Update freewheel-sspBidAdapter_spec.js

Fix the test error

* UserID Module: allow userid to ppid sync (#7681)

* sync PPID with googletag

* dont need to export

* add log warning if not right length

* EMX Digital Bid Adapter: add GPID support (#7720)

* adding ccpa support for emx_digital adapter

* emx_digital ccpa compliance: lint fix

* emx 3.0 compliance update

* fix outstream renderer issue, update test spec

* refactor formatVideoResponse function to use core-js/find

* Add support for schain forwarding

* Resolved issue with Schain object location

* prebid 5.0 floor module and advertiserDomain support

* liveramp idl and uid2.0 support for prebid

* gpid support

* remove utils ext

* remove empty line

* remove trailing spaces

* move gpid test module

* move gpid test module

* removing trailing spaces from unit test

* remove comments from unit test

Co-authored-by: Nick Colletti <nick.colletti@emxdigital.com>
Co-authored-by: Nick Colletti <gnomish@gmail.com>
Co-authored-by: Kiyoshi Hara <Kiyoshi.Hara@emxdigital.com>
Co-authored-by: Dan Bogdan <daniel.bogdan@emxdigital.com>
Co-authored-by: Jherez Taylor <jherez.taylor@emxdigital.com>
Co-authored-by: EMXDigital <emxdigital@emxdigital.com>
Co-authored-by: Rakesh Balakrishnan <Rakesh.Balakrishnan@emxdigital.com>
Co-authored-by: EMX Digital <43830380+EMXDigital@users.noreply.github.com>
Co-authored-by: Kevin <kevin.hagens@brealtime.com>

* Limelight Digital Bid Adapter: Add optional Publisher ID field (#7706)

* adyoulike Bid Adapter: Add userIds to bidrequest (#7660)

* add required clickurl in every native adrequest

* allows the native response to be given as is to prebid if possible

* add unit tests on new Native case

* Handle meta object in bid response with default addomains array

* fix icon retrieval in Native case

* Update priorities in case of multiple mediatypes given

* improve robustness and fix associated unit test on picture urls

* add support for params.size parameter

* add unit test on new size format

* Makes sure the playerSize format is consistent

* enable Vast response on bidder adapter

* fix lint errors

* add test on Vast format case

* add userId to bidrequest

* revert package-lock.json changes

* add first-party data support to beachfront adapter (#7733)

Co-authored-by: John Salis <john@beachfront.com>

* Prebid 6.2.0 Release

* Increment pre version

* SharedID module: update tests to assert on behavior rather than logs (#7738)

Update tests that fail spuriously: https://github.com/prebid/Prebid.js/issues/7355
I was not able to reproduce the failures, but in debugging I ruled out the possibility of module loading order and I believe the most likely culprit is other tests asynchronously calling `utils.logInfo` that sometimes happen in-between these tests' setup and assertions.

This may not be the real issue, but IMO testing log messages makes little sense anyway, so I updated them to test the actual SOT behavior.

* gumgum & adagio Bid Adapters: remove extra defensive code to solve lgtm alert (#7737)

* Update gumgumBidAdapter.js

* Update adagioBidAdapter.js

* 33acrossBidAdapter: Add Support for SRA (#7703)

* SRA support

* apply code review feedback SRA

* removed redundant config check

* Replace not-supported array flat method.

Co-authored-by: Carlos Felix <carlos.felix@33across.com>

* Remove redundant alias (#7742)

Fix an issue with the `gdprEnforcement` module. See #7741

* Lotame panorama id submodule: handle consent (#7644)

* feat: Add handling for a custom client id
feat: Send us privacy string

* test: Add test case to make sure the expiry is also not touched and update the mocked response

Co-authored-by: Mike Marcus <mike@lotame.com>

* Yahoo SSP Bid Adapter: interstitial fix  (#7746)

* ortb2Imp.instl

* ortb2Imp.instl unit-test

* numeric boolean validations

* refacotor for false 0

* tests stable

* Kinesso fixing the endpoint construction (#7743)

Co-authored-by: skocheri <skocheri@rubiconproject.com>

* VidoomyBidAdapter: fix video mediatype sizes format (#7716)

* fix: add delay between cookie sync calls

* fix(VidoomyBidAdapter): use default triggerPixel

* fix: use getUserSyncs hook to sync cookies

* fix: handle 204 no response without error log

* chore: refactor getUserSyncs

* test: update vidoomyBidAdapter tests

* fix: remove Macro

* fix: query params

* fix: gdpr consent

* fix: vidoomyBidAdapter tests

* fix: use USP_CONSENT in cookie sync urls

* fix(vidoomyBidAdapter): sizes format for video mediatype

* fix: vast xml

* fix: send gdpr as string

* chore: add adUnitCode to prebid request

* Prebid core: move generation of 'installedModules' to babel (#7739)

`pbjs.installedModules` does not work correctly when using prebid as an npm dependency (https://github.com/prebid/Prebid.js/issues/7287), because it's generated by a gulp task.

This moves generation of `installedModules` to the `pbjsGlobals` babel plugin that we ask npm consumers to use for prebid.

* Add 'targetingControls.addTargetingKeys' configuration option (#7690)

This adds 'addTargetingKeys' as a config option that means 'allow all default targeting keys, plus these'.

https://github.com/prebid/Prebid.js/issues/7249

* add alias futureads (#7753)

Co-authored-by: atkachov <atkachov@admixer.ua>

* Weborama Rtd Provider: access user profiles in local storage and add support to wam2gam and smartadserver (#7728)

* update .submodules.json to include weborama rtd

update .submodules.json to include weborama rtd submodule

* fix jsdoc

* add support to wam2gam

* fix unit test

* fix bad copy paste

* save dev

* add feature

* rename properties

* update unit tests

* fix doc

* fix doc ~

* fix doc 3

* rename bigsea contextual

* rename wam2gam

* refactor code

* rename setGAMTargeting

* improve doc, example

* update conf

* fix doc

* fix identation

* fix identation 2

* remove empty line into end

* remove empty line 2

* fix jsdoc

* add support to wam2gam

* fix unit test

* fix bad copy paste

* save dev

* add feature

* rename properties

* update unit tests

* fix doc

* fix doc ~

* fix doc 3

* rename bigsea contextual

* rename wam2gam

* refactor code

* rename setGAMTargeting

* improve doc, example

* update conf

* fix doc

* fix identation

* fix identation 2

* remove empty line into end

* remove empty line 2

* add intersection RtdProvider and spec (#7710)

Co-authored-by: atkachov <atkachov@admixer.ua>

Co-authored-by: AdmixerTech <35560933+AdmixerTech@users.noreply.github.com>
Co-authored-by: atkachov <atkachov@admixer.ua>

* Zeta Ssp Bid Adapter: vast xml for bid (#7740)

* vastXml as bid.ad

* test added

* logic with ext.bidtype

* fix tests

* fix tests(3)

* change .md for video support sample

Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>

* NextMillennium Bid Adapter: add getUserSyncs function (#7749)

* Add getUserSyncs function

* add unit tests

* add unit tests

Co-authored-by: mifanich <mihail.ivanchenko@nextmillennium.io>

* BeOp Bid Adapter: fix tracking params (#7759)

* [BeOp adapter] Fix tracking params

* Missing comma

* PBS Bid adapter: timeout user syncs if they never load (#7744)

* PBS Bid adapter: timeout user syncs if they never load

In some situations the browser never triggers load/error events for user syncs, so the PBS adapter remains stuck (https://github.com/prebid/Prebid.js/issues/6354). This adds a timeout for image/iframe syncs.

* Clear timeout in utils.waitForElementToLoad

* add one more get param to be forwarded (#7745)

* Update Criteo Fast Bid version (#7767)

* TargetVideo Bid Adapter: add new bid adapter (#7718)

* TargetVideo bid adapter

* TargetVideo bid adapter

* TargetVideo bid adapter

* TargetVideo Bid Adapter update

* TargetVideo Bid Adapter implementing requested changes

* Adman Bidder Adapter: add lotamePanoramaId (#7763)

* Add Adman bid adapter

* Add supportedMediaTypes property

* Update ADman Media bidder adapter

* Remove console.log

* Fix typo

* revert package-json.lock

* Delete package-lock.json

* back to original package-lock.json

* catch pbjs error

* catch pbjs error

* catch pbjs error

* log

* remove eu url

* remove eu url

* remove eu url

* remove eu url

* remove eu url

* Update admanBidAdapter.js

add consnet to sync url

* Update admanBidAdapter.js

fix import

* Update admanBidAdapter.js

lint fix

* Update admanBidAdapter.js

lint fix

* Update admanBidAdapter.js

check consent object data availability

* сompatible with prebid v5

* add Lotame Panorama ID

Co-authored-by: minoru katogi <mkatogi@gmail.com>
Co-authored-by: minoru katogi <m_katogi@hotmail.com>
Co-authored-by: ADman Media <admanmedia@users.noreply.github.com>
Co-authored-by: SmartyAdman <adman@localhost.localdomain>

* ZetaSspBidAdapter: provide media type (#7762)

* provideMediaType

* checkstyle issue

Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>

* Fix GDPR consent choice capture (#7779)

* Mediasquare bidder: remove old user sync method (#7780)

* remove old userSyncs method

* Update mediasquareBidAdapter.js

* Update mediasquareBidAdapter.js

* Update mediasquareBidAdapter_spec.js

* PubCommonID module: use topmost domain for cookie storage (#7773)

This reintroduces logic to have sharedIdSystem/pubCommonID use the TLD for cookie storage

* adxcgBidAdapter: updated backend protocol (#7750)

* adxcgBidAdapter: updated backend protocol

* adxcgBidAdapter: changed onBidWon from ajax() to triggerPixel()

Co-authored-by: dev adxcg.com <mark.vreg@gmail.com>

* Adnuntius Bid Adapter: no cookie feature. (#7768)

* Added option to pass a user id through ortb2.

* check if use cookie is present in config, and use it accordingly.

* Adding test for no cookie url addition.

* AdDefend Bidder: added gdprApplies to bid request parameters (#7782)

Co-authored-by: Mitschi <mitschi@addefend.com>

* fix usersync gdpr (#7785)

* Ventes Bid Adapter: fix web support and code maintenance (#7766)

* Ventes Avenues initial changes

* Ventes Avenues initial changes

* Support Web Placments

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placments

* Update for 'Adapters that may not handle GDPR-Applies correctly #7775' (#7788)

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

* PBS Bid Adapter: do not pass aspectratios in ORTB2 ext data if native image definition doesn't have ratio_height/ratio_width (#7722)

* Prebid server adapter: do not pass aspectratios in ORTB2 ext data if native image definition does not have ratio_height/ratio_width

* Prebid server adapter: include all valid aspect ratios in ext.aspectratios

* NextMillennium Bid Adapter: refresh_count for adUnitCode is added (#7754)

* refresh count

* Update tests

Co-authored-by: mifanich <mihail.ivanchenko@nextmillennium.io>

* Handle consent case where GDPR doesn't apply (#7783)

* Colossus SSP Bidder Adapter: add onBidWon() (#7758)

* add video&native traffic colossus ssp

* Native obj validation

* Native obj validation #2

* Added size field in requests

* fixed test

* fix merge conflicts

* move to 3.0

* move to 3.0

* fix IE11 new URL issue

* fix IE11 new URL issue

* fix IE11 new URL issue

* https for 3.0

* add https test

* add ccp and schain features

* fix test

* sync with upstream, fix conflicts

* Update colossussspBidAdapter.js

remove commented code

* Update colossussspBidAdapter.js

lint fix

* identity extensions

* identity extensions

* fix

* fix

* fix

* fix

* fix

* add tests for user ids

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* add gdpr support

* add gdpr support

* id5id support

* Update colossussspBidAdapter.js

add bidfloor parameter

* Update colossussspBidAdapter.js

check bidfloor

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter_spec.js

* use floor module

* Revert "use floor module"

This reverts commit f0c5c248627567e669d8eed4f2bb9a26a857e2ad.

* use floor module

* update to 5v

* fix

* add uid2 and bidFloor support

* fix

* add pbadslot support

* fix conflicts

* add onBidWon

* refactor

* add test for onBidWon()

* fix

Co-authored-by: Vladislav Isaiko <vladis@smartyads.com>
Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
Co-authored-by: Mykhailo Yaremchuk <m.yaremchuk@smartyads.com>

* RTD Module: add 'onBidRequest' event handler for RTD submodules (#7729)

* RTD: Add 'onBidRequest' event handler for RTD submodules

https://github.com/prebid/Prebid.js/issues/7078

* RTD module: update documentation

* Prebid 6.3.0 Release (#7795)

* Increment pre version

* Improve Digital adapter: support for Google's additional consent (#7787)

* HBT-156: Added Google's additional consent (#1)

* HBT-156: Added Google's additional consent

* HBT-156: Code refactored

Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com>

* Update improvedigitalBidAdapter.js

Updated version

Co-authored-by: Samiul Amin Shanto <93644987+samiul-shanto@users.noreply.github.com>
Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com>

* CircleCi Config: change to npm ci in testing workf (#7732)

* Build system: improve build for development workflow (#7778)

* Build system: improve build for development workflow

This adds a "test-only" gulp task that runs only tests (without clean/lint) and makes the single-spec test environment consistent with the whole-suite case.

* Build system: remove tests from 'serve-fast' task; add 'serve-and-test' task

* update gpid / adslot logic (#7794)

* Pubx.ai Analytics Adapter: added additional fields to the Auction object (#7723)

* Update: Added additional fields to auction object

* Removed export from getStorage function

* Aniview Bid Adapter: add a new alias (#7807)

* Support new aniview bid adapter

* Support new aniview bid adapter

* Support new aniview bid adapter

* Support new aniview bid adapter

* Fix Consent parameters

* Update aniviewBidAdapter.js

V3 support

* Update aniviewBidAdapter.js

* Update aniviewBidAdapter.js

Update refererInfo

* Update aniviewBidAdapter.js

Fix tabs and spaces

* Update aniviewBidAdapter.js

fixes

* Update aniviewBidAdapter.js

* Update aniviewBidAdapter.js

Add ccpa support

* Update aniviewBidAdapter.js

Typo

* Update aniviewBidAdapter.js

* Update aniviewBidAdapter.js

* Fix size and sample

Fixed sizes from playerSize
Updated md sample

* Fix tabs

* Fix sizes

* Recheck

* Add tgt parameter

* Update sample

* Add support for cookie sync + tests

* Add support for cookie sync + tests

* Add support for cookie sync + tests

* Support aliases

Support aliases

* Update

Update

* Fix lint

Fix lint

* Update spec

Update spec

* Aniview Bid Adapter: Added the new alias

* Aniview Bid Adapter: Added …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants